Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update to new docker-py dependency once released #872

Closed
VukW opened this issue May 22, 2024 · 5 comments · Fixed by #943
Closed

[FEATURE] Update to new docker-py dependency once released #872

VukW opened this issue May 22, 2024 · 5 comments · Fixed by #943
Assignees
Labels
good first issue Good for newcomers

Comments

@VukW
Copy link
Contributor

VukW commented May 22, 2024

Currently (on 2024-05-24) the latest version of docker python package is 7.0.0.
However, acouple of days ago new requests library was released, 2.32.0.
docker package is not compatible right now with new requests version, so we downgraded #871 requests depencency to 2.31.0.

What to do: once new docker version released (I velieve it should be like 7.0.1) , remove dependency restriction on requests and update requests to 2.32.0

Copy link
Contributor

Stale issue message

@VukW VukW added good first issue Good for newcomers and removed no-issue-activity labels Jul 22, 2024
@sarthakpati
Copy link
Collaborator

@VukW the new docker version is up. I think could potentially tie in well with #875, but needs to go in as a separate PR. @benmalef do you want to take this on as well?

@benmalef
Copy link
Contributor

@sarthakpati yes I can take a look.

@benmalef
Copy link
Contributor

benmalef commented Sep 9, 2024

Hi guys @VukW , @sarthakpati

I have tried to update the requests version to 2.32.0 and the dockerversion to 7.1.0.
But, this error has been raised.

image

I open this PR:
benmalef#22 (comment)

Maybe, it is not ready to update.

@sarthakpati
Copy link
Collaborator

I don't have any detailed insight apart from what's posted on docker/docker-py#3256

Perhaps @VukW can shed some light?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants