Let hypothesis decide when to add optional keys #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this decision was evaluated once when creating the generator and never again meaning the shape of the dictionary would be static through the entire test run. The fix introduces a sentinel value that is randomly drawn next to the actual value strategy and is then filtered to exclude the key from the dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this decision was evaluated once when creating the generator
and never again meaning the shape of the dictionary would be static
through the entire test run.
The fix introduces a sentinel value that is randomly drawn next to the
actual value strategy and is then filtered to exclude the key from the
dictionary.