Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-JS : Wallet: Support transactions to multiple recipients #1

Closed
AltiMario opened this issue Feb 23, 2024 · 6 comments
Closed

FE-JS : Wallet: Support transactions to multiple recipients #1

AltiMario opened this issue Feb 23, 2024 · 6 comments
Assignees
Milestone

Comments

@AltiMario
Copy link
Contributor

Issues Fix in web-based wallet (Off-Narrative-Labs/Tuxedo#62) The current implementation of a CLI-based wallet allows sending inputs from multiple owners in a single transaction, but it only supports a single recipient for all specified outputs.

@AltiMario
Copy link
Contributor Author

this ticket was in our proposal, can we consider it closed? (by them or us?)

@AltiMario AltiMario moved this to Backlog in TuxedoDapp Feb 23, 2024
@AltiMario AltiMario added this to the DApp Core milestone Feb 23, 2024
@NadigerAmit
Copy link

@AltiMario

Blockchain-side implementation is already inplace.No restrictions for this in BC side.
This is not implemented on the CLI-wallet side. I will implement this this week.
This can be implemented in the JS wallet without dependency on CLI-wallet.

Multiple recipients and output coins need to be linked by each recipient. Struct something like the below

struct output_per_recipients {
pub recipient: H256,,
pub output_amount: Vec,
}

#[derive(Debug, Args)]
pub struct SpendArgs {
#[arg(long, short, verbatim_doc_comment, value_parser = output_ref_from_string)]
pub input: Vec,

#[arg(long, short, verbatim_doc_comment, value_parser = h256_from_string, default_value = SHAWN_PUB_KEY)]
pub output:Vec<output_per_recipients >,

}

@NadigerAmit
Copy link

Current situation :
Cli-Wallet implementation is pending.
Blockchain side implementation is ready.
JS Wallet can proceed with implementation.No blocking

@AltiMario AltiMario moved this from Backlog to In progress in TuxedoDapp Feb 26, 2024
@NadigerAmit NadigerAmit changed the title Wallet: Support transactions to multiple recipients FE-JS : Wallet: Support transactions to multiple recipients Feb 27, 2024
@NadigerAmit NadigerAmit moved this from Dev-In progress to Blocked in TuxedoDapp Feb 27, 2024
@NadigerAmit NadigerAmit removed their assignment Feb 27, 2024
@NadigerAmit NadigerAmit moved this from Blocked to Backlog in TuxedoDapp Feb 27, 2024
@AltiMario AltiMario assigned philoniare and unassigned Winni- Apr 15, 2024
@AltiMario
Copy link
Contributor Author

The frontend part is missing, but having it also means changing the workflow and interface. It is not a priority for the grant scope. It can stay in the backlog until we decide to implement it as an extra feature to show the potentiality of UTXO.

@NadigerAmit
Copy link

@AltiMario - This is already implemented in the wallet side.

Please see the implementation in

Implementation using Approach1 is done : Off-Narrative-Labs/Tuxedo#62 (comment)

Test result using approach1: Off-Narrative-Labs/Tuxedo#62 (comment)

Pending item is : Update the cli-wallet README file based on the approach2.

This implementation is submitted to "webservice-with-external-signing" branch.

@github-project-automation github-project-automation bot moved this from Backlog to Done in TuxedoDapp Apr 16, 2024
@JoshOrndorff
Copy link
Contributor

A PR back upstream for this is welcome too if time permits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants