Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UUID generator #259

Open
kevindrosendahl opened this issue Oct 5, 2018 · 0 comments
Open

update UUID generator #259

kevindrosendahl opened this issue Oct 5, 2018 · 0 comments

Comments

@kevindrosendahl
Copy link
Collaborator

kevindrosendahl commented Oct 5, 2018

currently using https://github.com/satori/go.uuid which should not be used (satori/go.uuid#84).

want to move to a mode of not prefixing cross-cutting resource names (e.g. creating an address.lattice.mlab.com for service 123e4567-e89b-12d3-a456-426655440000 should just have the name 123e4567-e89b-12d3-a456-426655440000 rather than lattice-service-123e4567-e89b-12d3-a456-426655440000)

however to do this we must rely on the UUIDs being truly unique (which is reasonable assuming we're using a correct UUID generator https://stackoverflow.com/questions/2977593/is-it-safe-to-assume-a-guid-will-always-be-unique)

so we should ensure we're using a correct UUID generator. probably want to just replicate this: https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/staging/src/k8s.io/apimachinery/pkg/util/uuid/uuid.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant