Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a generic component that combines load from parquet and load from hub #475

Closed
PhilippeMoussalli opened this issue Sep 28, 2023 · 3 comments
Closed

Create a generic component that combines load from parquet and load from hub #475

PhilippeMoussalli opened this issue Sep 28, 2023 · 3 comments
Assignees
@PhilippeMoussalli
Labels
Components Implementation of components

Comments

@PhilippeMoussalli
Copy link
Contributor

No description provided.

@PhilippeMoussalli PhilippeMoussalli converted this from a draft issue Sep 28, 2023
@PhilippeMoussalli
Copy link
Contributor Author

Related to #474 (review)

@PhilippeMoussalli PhilippeMoussalli mentioned this issue Sep 28, 2023
Merged
@PhilippeMoussalli PhilippeMoussalli moved this from Ready for development to In Progress in Fondant development Oct 3, 2023
@PhilippeMoussalli PhilippeMoussalli self-assigned this Oct 3, 2023
@RobbeSneyders
Copy link
Member

As discussed offline, I don't think we should merge these. The LoadFromHub component should be able to download datasets from HF hub in different formats. We can either have a separate LoadFromParquet component, or merge it with the LoadFromFiles component.

@RobbeSneyders RobbeSneyders moved this from In Progress to Breakdown in Fondant development Oct 5, 2023
@RobbeSneyders RobbeSneyders moved this from Breakdown to Backlog in Fondant development Oct 5, 2023
@RobbeSneyders RobbeSneyders added the Components Implementation of components label Oct 11, 2023
@PhilippeMoussalli
Copy link
Contributor Author

ok closing this

@github-project-automation github-project-automation bot moved this from Backlog to Done in Fondant development Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippeMoussalli PhilippeMoussalli

Labels
Components Implementation of components
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobbeSneyders @PhilippeMoussalli