Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColSpan example cutting off 1st row and not aligning in IE9 #115

Closed
haasey opened this issue Sep 23, 2014 · 12 comments
Closed

ColSpan example cutting off 1st row and not aligning in IE9 #115

haasey opened this issue Sep 23, 2014 · 12 comments

Comments

@haasey
Copy link

haasey commented Sep 23, 2014

This fiddle looks fine in chrome and firefox, but in IE9 it completely hides the 1st row and also the column header for column 2 does not line up with the row's header for column 2. http://jsfiddle.net/57srq9ky/1/
I did make sure IE is not running compatibility mode.

I read another issue about putting the colspan in the header but that wouldn't really work for me.
While this example shows all the rows with colspan 2, I won't really know that until I pull the data back from an ajax call. My first github posting so if I'm not being clear enough please be patient with me.

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

Eek IE9.

I dont have it on my mac right now, so can you tell me if the following updated code fixes the problem:
http://jsfiddle.net/57srq9ky/3/

if it does, we should think about how to update your code to insert such a row into your table which contains no colspans.

does this example work for you in IE9:
http://mkoryak.github.io/floatThead/examples/row-groups/

Your first github post was better than 99% of first posts 👍

@haasey
Copy link
Author

haasey commented Sep 23, 2014

So the updated fiddle gets closer but not quite there. Even though you have 0 as the height I see half the 1st row you added.. This may be related to bootstrap which I am trying to find out.

The example which I didn't see before about getSizingRow actually doesn't quite work in IE9 for me. The columns are a bit off for rows after the colspan on row 1. I'm not sure this is exactly the same since I am not trying to do a window scroll, more of the scroll inside an individual div.

Thanks for your time.
-Chris

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

ok, do any of the examples on the site work in ie9 for you? I might have broken support for over the last few releases since I dont have one to test in. Can you see if this older release works for you:

https://github.com/mkoryak/floatThead/releases/tag/v1.1.1

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

So the updated fiddle gets closer but not quite there. Even though you have 0 as the height I see half the 1st row you added.. This may be related to bootstrap which I am trying to find out.

height is not the only property that controls height of elements, there is also line-height, padding, margin and maybe a few more i cant remember. its possible to get the height of those things to be 0, i have done it.

@haasey
Copy link
Author

haasey commented Sep 23, 2014

having some trouble with the zip. No index.htm file to test with.
I tried to just use the jquery.floatThead.min.js in my sample but I get an error.
ReferenceError: _ is not defined
http://localhost:58750/Scripts/jquery.floatThead.min.js
Line 8

I am a bit new to git, if there is a online way to get an older copy it would probably be easier for me to do a fiddle using an old version of jquery.floatThead.min.js

I was messing with the style line-height etc. I'm not giving up but haven't gotten the magic style yet. If I do I will post a fiddle for others to use.

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

that old version requires underscore:
http://cdnjs.cloudflare.com/ajax/libs/underscore.js/1.7.0/underscore-min.js

@haasey
Copy link
Author

haasey commented Sep 23, 2014

http://jsfiddle.net/57srq9ky/24/

This is my workaround for the current version. Sorta a hack since I'm making a jquery call to hide the 1st row that is needed to get the widths of the columns.
I suppose you can boo me ;)

I will try to test with your underscore as well an update this thread.

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

Does that workaround still work if you resize the window such that the width of the table changes?

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

also, google around for a solution. people mention setting overflow to hidden etc:

https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=css%20set%20table%20row%20height%20to%200

@haasey
Copy link
Author

haasey commented Sep 23, 2014

I confirmed the workaround does work with resize. The reason I think I have to use javascript instead of css is that you must call to floatThead must before you hide the rowThe jquery hide I apply is really just doing a display: none but if I put that in css then the floatThead call doesn't give me the headers like I want. Hence I don't think any css trick to hide it will help since it can't be hidden initially.

I realize old browser stuff is a pain, but so many people still have win7 IE9 in a corporate setting...sigh.
I really do like this addin, I really hate Internet Explorer, and I really do appreciate your time.

@mkoryak
Copy link
Owner

mkoryak commented Sep 23, 2014

Im glad it worked for you. Sorry I couldn't help you more but having no windows PCs makes it that much more of a pain to support it - so I'm leaving the IE pain to those who get paid for it :)

@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants