Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Password prompt #48

Closed
awyl opened this issue Mar 17, 2018 · 8 comments
Closed

Password prompt #48

awyl opened this issue Mar 17, 2018 · 8 comments

Comments

@awyl
Copy link

awyl commented Mar 17, 2018

Description

Just switched from the "classic" version. Password is not prompted for sftp. I tried to use the prompt target, but the password is not remembered.

Actual behavior

None.

Expected behavior

Prompt for password when the password is not provided in settings.

@mkloubert
Copy link
Owner

@awyl

I have implemented that feature in version 0.62.1, for SFTP and FTP targets.

If you do not define an username and/or password (or set them to (null)), input boxes are shown and those values are cached by default for the current editor session.

You can control the cache behavior by defining the alwaysAskForPassword and/or alwaysAskForUser settings.

@mkloubert
Copy link
Owner

@awyl

Sorry, I forgot to merge from branch.

The feature should be available since the new version 0.62.2 now.

@awyl
Copy link
Author

awyl commented Mar 18, 2018

Thanks for responding so quickly. Right now it works very well. I have one more request though. The password is shown in plain text as we type, can it be masked?

@mkloubert
Copy link
Owner

@awyl

Sorry, of course! ... Should be available since version 0.63.0.

@awyl
Copy link
Author

awyl commented Mar 19, 2018

Nice and thanks! Work perfectly!!

@awyl awyl closed this as completed Mar 19, 2018
@robert914
Copy link

robert914 commented Mar 19, 2018

I think I see an issue with this now. I have been using SFTP with a defined "privateKey" setting (i.e. which requires no password), and therefore, I don't have a password defined. However, now every time I start a new season and then use deploy, it now asks for a password. If I just hit "Enter" it happily transfers since it has the privateKey setting, and it stops asking for the current session. However, every new restart of the application or open of a workspace, it asks again.

This password requirement should not happen if the user has a "privateKey" setting, as it won't be needed. I think this is being ignored now for this new password prompt check.

Example config setup:

        "targets": [
            {
                "type": "sftp",
                "name": "Remote",
                "description": "Remote target",
                "host": "myhost.server.com",
                "port": 22,
                "user": "robert",
                "privateKey": "${homeDir}/.ssh/id_rsa_remote",
                "dir": "/home/robert/src/project1",
                "modes": 644,
                "debug": true
            }

Can you please fix this?

FYI, I can't seem to re-open this ticket, so should I create a new one?

@mkloubert
Copy link
Owner

mkloubert commented Mar 20, 2018

@robert914 @awyl

Thanks a lot! The issue should be fixed since version 0.64.0.

If there are still issue(s) according to that new feature, you should open a new entry.

@robert914
Copy link

Works perfect again! Thanks for the fast fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants