Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Mappings setting not including hidden files #28

Closed
jimschmit opened this issue Feb 18, 2018 · 2 comments
Closed

Mappings setting not including hidden files #28

jimschmit opened this issue Feb 18, 2018 · 2 comments

Comments

@jimschmit
Copy link

jimschmit commented Feb 18, 2018

Description

Hello, I have a .htaccess file for my server that I also want to deploy.
My mapping looks like this now to make it work:

"dir": "/htdocs/",
				"mappings": {
					"frontend/**/*": "/",
					"frontend/.htaccess": "/",
				}

But shouldn't this config also work when I only use "frontend/**": "/" ?
Without the second line, it creates a frontend folder inside the htdocs folder...

@mkloubert
Copy link
Owner

mkloubert commented Feb 18, 2018

@jimschmit

I think it has to do with the format of minimatch patterns.

The first pattern does not match with .htaccess, because the file starts with a dot, so you have to define it explicitly, I think.

@mkloubert
Copy link
Owner

@jimschmit

I changed the behavior in version 0.52.1, so folder mappings will work as expected with "dot files" now, or in other words: you do not need the 2nd pattern anymore.

I forgot to set required options (like dot and nocase), when using minimatch module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants