Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

[Feature Request] Support of Ed25519 SSH keys #99

Closed
rmrnc opened this issue Aug 20, 2017 · 5 comments
Closed

[Feature Request] Support of Ed25519 SSH keys #99

rmrnc opened this issue Aug 20, 2017 · 5 comments

Comments

@rmrnc
Copy link

rmrnc commented Aug 20, 2017

Hi,
Unless I am missing something, Ed25519 SSH keys are not supported for sftp targets. Not the end of the world, but a bit annoying.

Thank you.

@mkloubert
Copy link
Owner

@rmrnc

I am using ssh2-sftp-client for SFTP.

I am not sure if it is possible to use the key format there.

Is there a way to convert?

@mkloubert
Copy link
Owner

mkloubert commented Aug 21, 2017

@rmrnc

I have find a way to convert keys. I am using sshpk module for that.

Since version 9.32.3, you can set the privateKeySourceFormat property to define the source format of your private key.

{
    "deploy": {
        "targets": [
            {
                "type": "sftp",

                "user": "mkloubert",

                "privateKey": "/.ssh/id_rsa",
                "privateKeySourceFormat": "auto",

                // ....
            }
        ]
    }
}

By default it will convert this to ssh format, This change be changed by setting up privateKeyTargetFormat.

@rmrnc
Copy link
Author

rmrnc commented Aug 21, 2017

Thank you for your quick response, but I am not entirely sure whether we are on the same page. I'd opted intentionally for elliptic-curve keys and specifically for an Ed25519 key (admittedly, a quite popular choice within the security community). Therefore, I am afraid to say that "(format) conversion" is not the issue. It appears to me, that the SSH client you are employing has omitted support for this kind of SSH keys. Let me know whether you need more information about the cryptographic background.

@mkloubert
Copy link
Owner

@rmrnc

Ah, OK. I wasn't really sure if a conversion is the really answer.

But on the other hand I have implemented a new, useful feature :D

Yes, tell me the background. What I currently see is, that this is a problem of the SSH client.

But I am not sure if there is a NodeJS module that supports this feature.

@HLFH
Copy link

HLFH commented Jun 22, 2021

Related to: TritonDataCenter/node-sshpk#72

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants