Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume support #35

Closed
neersighted opened this issue May 5, 2022 · 2 comments
Closed

Volume support #35

neersighted opened this issue May 5, 2022 · 2 comments
Labels

Comments

@neersighted
Copy link

Volumes can have a custom icon set by creating /.VolumeIcon.icns, where / represents the volume root. Currently fileicon will set volume icons as it uses AppleScript, but it will return an error as it is not aware of how to read back a volume's icon.

@mklement0
Copy link
Owner

Thanks, @neersighted - sorry it took me so long to respond.

Given a folder path, how can you tell whether it is a volume mount point?

Or are all volumes mount points invariably? by convention? are subfolders of /Volumes?

@mklement0
Copy link
Owner

@neersighted, I've just published v0.3.2, which adds support for volumes in pirinciple.

However, as of macOS 13.1 (Ventura), I see inconsistent support for assigning icons to volumes,
for which I have no explanation:

The underlying Cocoa API call mostly only half succeeds:

It creates the .VolumeIcon.icns helper file, but quietly fails to set the custom-icon flag in the
com.apple.FinderInfo extended attribute of the mountpoint folder.

See this Ask Different question question for how others are experiencing similar problems.

The read-me now contains a warning about the lack of predictable support.

I'm closing this, due to v0.3.2 now trying the best it can to support volume icons, but if you have insights on how to make the support more predictable, I encourage you to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants