Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img task copies jpgtmp.jpg to publish/intermediate folders #49

Open
jahvi opened this issue Jul 15, 2012 · 3 comments
Open

Img task copies jpgtmp.jpg to publish/intermediate folders #49

jahvi opened this issue Jul 15, 2012 · 3 comments

Comments

@jahvi
Copy link

jahvi commented Jul 15, 2012

For some reason a jpgtmp.jpg file is getting copied to my mkdirs folders, the images themselves are getting minified just fine though.

@mklabs
Copy link
Owner

mklabs commented Aug 7, 2012

Probably due to a clumsy implementation of the img task =/ It's related to jpegtran helper.

https://github.com/h5bp/node-build-script/blob/master/tasks/img.js#L83-114

This is used as a temporary file, as the -output option for jpegtran. Could probably clean and delete this file once the task is done though.

@sylvinus
Copy link

sylvinus commented Jan 4, 2013

I'm also getting this file as a leftover in dist/

@mklabs
Copy link
Owner

mklabs commented Jan 9, 2013

Is it something still up with latest from master? #64 should have fix it.

There is now a lot of grunt plugins for image optims, including yeoman/node-jpegtran-bin and @heldr's grunt-img (which is a fork and reworked version of the img task in use here). I'm considering removing the task from the repo and use one of these tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants