Implement a portion of responseType #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-co-authored-by: Paul Ringseth <[email protected]>
Handle definition of responseType with a getter/setter, and change when this.response is set to conform to the XML spec. Only responseTypes of '', 'text', and 'arraybuffer' were fully added
|
This is indirectly tested by |
|
Man I think I'm blind. Just realized that a full implementation of this was done by Paul in #16. Closing this MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://xhr.spec.whatwg.org/#the-responsetype-attribute, up to the responseTypes of '', 'text', and 'arraybuffer'.
Includes some changes to response to use the new responseType, as well as better conformance for when values become available (only once the state is done does response become available, not being updated as each data segment arrives)