Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on redux-simple-router? #1

Closed
mjrussell opened this issue Jan 19, 2016 · 3 comments
Closed

Remove dependency on redux-simple-router? #1

mjrussell opened this issue Jan 19, 2016 · 3 comments
Labels

Comments

@mjrussell
Copy link
Owner

Currently there is a hard dependency on redux-simple-router due to https://github.com/mjrussell/redux-auth-wrapper/blob/master/src/index.js#L2

The replace (or push) action creator could easily be passed in as an argument. Is it better to add this option or make it convenient since simple router is the rackt approved method?

@mjrussell
Copy link
Owner Author

I think this library should be agnostic to the routing library used, making it work with both redux-router and redux-simple-router

Going to provide an option for specifying the action creator to call and default to the history prop passed down

@jbach
Copy link

jbach commented Feb 2, 2016

Until you’ve decided, you should replace redux-simple-router with react-router-redux, the project has been renamed/deprecated.

@mjrussell
Copy link
Owner Author

@jbach thanks will do. I've decided to take out the hard dependency anyway but will allow users to specify their own route actions to dispatch if they want. I'll try to do this and #8 today and get a new release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants