Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Symfony components to ~6.0 #104

Open
PAXANDDOS opened this issue Feb 10, 2023 · 2 comments · Fixed by #111
Open

Bump Symfony components to ~6.0 #104

PAXANDDOS opened this issue Feb 10, 2023 · 2 comments · Fixed by #111

Comments

@PAXANDDOS
Copy link
Contributor

PAXANDDOS commented Feb 10, 2023

Hi!
Symfony 6.0 has released more than a year ago, and 6.3 is rolling out soon.
I was surprised that you haven't updated your components to 6.0 yet. Also good to see that you are working hard on the project since the 3.0 release!

Your php-resque is a literal rescue for my project right now, and the only thing that blocks the installation is locked Symfony components. I was wondering if you could update them soon? 🥺 My problem is with Symfony Console, had to downgrade it for now

Also, I've seen the #78 issue, and dependency reduction might be quite useful! For example, symfony/yaml can be moved to optional dependencies if you add support for pure PHP configuration files. That's just my opinion

@xelan
Copy link
Collaborator

xelan commented Feb 15, 2023

Hi @PAXANDDOS, thank you very much for your interest in php-resque and your issue(s). I didn't have time to test php-resque with Symfony 6.x yet, however I'm open to a PR. As you mentioned in #105, the process construction for the speed test would need to be changed, and the compatbility of the other used components (console, yaml) needs to be tested. Would you like to give it a try?

The solution of #78 and a possible PHP-only configuration would be great, but unfortunately I cannot create a new project in the mjphaynes namespace to enable such change.

Best regards
Andreas

@PAXANDDOS
Copy link
Contributor Author

Thanks for your answer @xelan!
I actually forked php-resque a few days ago and tried to make some changes, like bringing a new Docker environment-- but couldn't go far because of a bunch of weird errors with weird fixes (for example, bin/resque wouldn't work until I saved it with formatting (only converted CRLF to LF)). Also not sure if I can fix issues like #106 and #107 (and really need help with #109) because I don't really know the codebase.

I'll consider making another shot, but not on weekdays for sure, very busy as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants