Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mj-social-element contains icons from mailjet.com that no longer exist #2551

Closed
stefanisak opened this issue Sep 23, 2022 · 3 comments
Closed

Comments

@stefanisak
Copy link

Describe the bug
<mj-social-element /> includes broken images from mailjet.com

To Reproduce

Just use the example from the docs:

<mj-social>
   <mj-social-element name="facebook">Share</mj-social-element>
</mj-social>

renders

[...]
<img height="20" src="https://www.mailjet.com/images/theme/v1/icons/ico-social/facebook.png" style="border-radius:3px;display:block;" width="20">
[...]

And https://www.mailjet.com/images/theme/v1/icons/ico-social/facebook.png does not exists => 404

try online

Expected behavior
Should use icons that exists.

MJML environment (please complete the following information):

  • OS: MacOS
  • MJML Version 4.13.0
@TingWeiKe
Copy link

same here.

@brianschroeter
Copy link

Confirmed. I'm seeing the same thing here.

@iRyusa
Copy link
Member

iRyusa commented Oct 4, 2022

This is fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants