Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different ideas on what "3 months ago" should mean #5

Open
zostay opened this issue Nov 13, 2012 · 2 comments
Open

Different ideas on what "3 months ago" should mean #5

zostay opened this issue Nov 13, 2012 · 2 comments
Labels

Comments

@zostay
Copy link
Contributor

zostay commented Nov 13, 2012

I received an internal bug report today stating:

Today I discovered a bug related to the use of "3 months ago". In this case, the resultant dataset is for a single day three months ago (8/12/12). I would expect to see all payments for August.

Looking into the tests I see this case:

{
    description       => '3 months ago from June 15 is March 15',
    date_range_string => '3 months ago',
    as_of         => '2013-06-15',
    beg           => '03/15/2013 12:00AM',
    end           => '03/15/2013 11:59PM',
}

Clearly, the choice to make this a single day 3 months ago is deliberate. I don't know if there is a fix for this, but something to consider.

@mjaquilina
Copy link
Owner

I'm currently inclined to leave the behavior as-is. In my mind, "3 months ago" refers to a precise point in time, whereas "last month" and "next month" more generally refer to the entirety of a specific month.

This is mostly because I use "[n] months ago" searches fairly often to review email and whatnot, so that may just be a personal bias. I'm going to leave this open for now in case anyone else has opinions on the topic. (This assumes that people use D::RP::EN, which is perhaps a bit of a stretch.)

@zostay
Copy link
Contributor Author

zostay commented Nov 14, 2012

I have no strong feelings any which way. I am but a conduit on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants