Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch C++ AutoBuilder std::functions to accept const& #879

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Switch C++ AutoBuilder std::functions to accept const& #879

merged 2 commits into from
Oct 22, 2024

Conversation

bhall-ctre
Copy link
Contributor

The C++ AutoBuilder lambdas can take const references instead of values. WPILib typically passes Pose2d and ChassisSpeeds by const reference, and the DriveFeedforwards type contains vectors that shouldn't be copied on every call to output.

@bhall-ctre
Switch C++ AutoBuilder functions to accept const&
574df5a 
The AutoBuilder lambdas can take const references instead of values.
@github-actions github-actions bot added the PathPlannerLib Changes to PathPlannerLib label Oct 22, 2024
@mjansen4857 mjansen4857 merged commit 49fb344 into mjansen4857:main Oct 22, 2024
24 checks passed
@bhall-ctre bhall-ctre deleted the lambda-take-const-ref branch October 22, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PathPlannerLib Changes to PathPlannerLib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhall-ctre @mjansen4857