Add driver station warning if named command is not known #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think reporting a warning or error makes sense over throwing since it allows for easily disabling certain markers for testing just by commenting out the lines that register them, without having to delete them from the path. Can you add the same warning for python as well. Relevant line is here. You'd need to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My kids had a capitalization problem with a named command and didn't know why their thing wasn't getting scheduled. By at least logging a warning, there is some insight to what is going wrong.
Alternatively, you can hard fail with an exception. I think it is bad that there can be a discrepancy that silently fails between what you see in the gui and what gets run on the robot.