Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beatgrid off often,vamp plugin parameter. #9695

Closed
mixxxbot opened this issue Aug 23, 2022 · 10 comments
Closed

Beatgrid off often,vamp plugin parameter. #9695

mixxxbot opened this issue Aug 23, 2022 · 10 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kek001
Date: 2019-07-18T17:22:33Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1837092


More than 90% of time i need to adjust beatgrid,

and is often more of than 0.02 or 0.04

Lot of manual i mean lot of work and done it two times when mix 2.0 came.

I dont know would it help if i can change parameter, which finds/suitable better songs where is percussion,strong bass drum,bass etc...

I am scratching my head, Mixxx is promoting accurate detection in documents.
For Trance and Psychill music, mixxx is not accurate at all, how its locating beatggrid.
and Should be very easy task comparing ambient style music.

i mean this document from vamp plugins.


Parameters

Beat Tracking Method – The method used to track beats. The default, "New", uses a hybrid of the "Old" two-state beat tracking model (see reference Davies 2007) and a dynamic programming method (see reference Ellis 2007). A more detailed description is given below within the Bar and Beat Tracker plugin.

Onset Detection Function Type – The algorithm used to calculate the onset likelihood function. The most versatile method is the default, "Complex Domain" (see reference, Duxbury et al 2003). "Spectral Difference" may be appropriate for percussive recordings, "Phase Deviation" for non-percussive music, and "Broadband Energy Rise" (see reference, Barry et al 2005) for identifying percussive onsets in mixed music.

Adaptive Whitening – This option evens out the temporal and frequency variation in the signal, which can yield improved performance in onset detection, for example in audio with big variations in dynamics

https://vamp-plugins.org/plugin-doc/qm-vamp-plugins.html#qm-tempotracker

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-07-19T12:03:10Z


You are right, that the results of the beat detection can be improved. However I am in doubt that additional parameters will improve the situation. They would be overwhelming for new users and not easy to adjust.
We need a kind of auto tweak solution.

Here is a pending PR that should improve the situation a bit. I have also some ideas to improve it further.
#2152

Do you have a reference track that fails or works or has a significant off beat that could be solved?

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: kek001
Date: 2019-07-19T19:57:22Z


Thank you for reply
I am not sure also would tweaking vimp plugin parameters help, have seen some application you can switch beat tracking for dance music.

I have tons of examples, but without sending any of those.
There is excellent free for home use web portal, where are lot of music, pick there something
from psytrance or goa trance or progressive or downtempo.

Its somehow intresting that beatracker find better popular music than those strong bass and drumss dance songs which i think should be much easier. but they can also be quite dynamic and starting long intro, and often composers do many minutes areas where dj can syn they decks/tracks.

https://ektoplazm.com/

@mixxxbot
Copy link
Collaborator Author

Commented by: kek001
Date: 2019-07-19T19:58:14Z


sync*

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-07-19T22:07:33Z


Ok, I will have a look there. Do you have a specific track we can discuss? I only need title and artist for looking it up at Youtube or Spotify.

@mixxxbot
Copy link
Collaborator Author

Commented by: kek001
Date: 2019-07-19T22:13:01Z


Also i dont know is it bad or good for workflow what i do.
Like about 15-20% BPM is wrong, and theory you need good BPM to do good key chord. or some methods.
So now i am using other applications to do key analysing, and renaming labeling songs, and genres fixing file names, and then adjusting grids and trying to put hot ques and thinking which songs its good fox mix together, or where i can loop or remix something.
If i can take any of these steps away, like adhusting beat grid, it helps me lot, because its not interupt my work flow.

Maybe if i have to work more with song,it make me remeber it better and it leaves my brain more stronger footprint. so its 50/50

i have been thinking long should i write this beat grid problem at all.
Because i like Mixxx very much. and some things how you do ,develope things you are industry leaders and pushing commercial application try to do things better, i am very proud and happy user of mixxx.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-07-19T22:36:50Z


Thank you for the kind words (๑>◡<๑)

I have found:
Globular - For The Time Being
It is detected as 130 BPM even it is a 65 BPM track.
That is OK, but the beats are 0.02 s too early. I will investigate why.

@mixxxbot
Copy link
Collaborator Author

Commented by: kek001
Date: 2019-07-26T20:04:20Z


Globular songs are interesting because they play dub/psydub. and are some time more complex than most electronic music and are not allways 4/4 . or tempo can vary
But if you try some goa trance or progressive trance where is strong bass and drumm downbeat.
grid can be much far than 0.02 or 0.08.
For human it looks from waveform or ear much easier. i dont know is something to about usually songs can be about 1 min or more intro, before they start, and it mess the algorithm.
Because other style of music are 3-5 minutes, but electronic songs are usually much more longer.
intro and outro are not composed as abc

just a guess.

I havent tested with classical music what vamp will do. i will test.

I hope you dont think this as insult because i dont know what kind of genres you are listening and playing, i mean trying to baby feeding. i just try to explain my thoughts someway.

@mixxxbot
Copy link
Collaborator Author

Commented by: mixxx-zulip
Date: 2019-07-28T10:35:14Z


#2152
Fixes a technical issue resulting in a too early beat-grid.
This lints this bug but is not a complete fix.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-08-08T07:37:46Z


The PR has been merged and the next master builds should include this fix.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant