right click "Add to Playlist"+"Add to Crate" items for tracks should have "new" as option

[mixxxbot]

Reported by: rawrr
Date: 2013-05-12T00:03:33Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1179097
Tags: crate, crates, easy, gui, menu, menus, playlist, playlists
Attachments: bug1179097v1.patch

---

I know that you could just create a new playlist or crate beforehand and then add selected tracks to it. However, it would be smoother and faster for it to also be connected to right click options for selected tracks, especially since other playlist and crate functions are present there too.

[mixxxbot]

Commented by: vedu
Date: 2013-05-18T20:33:13Z
Attachments: bug1179097v1.patch

---

Attached patch fixes the bug. It Builds and runs as expected.

However, there was a lot of code duplication between the 2 (playlist and crate). Also, I mainly copied code from the BasePlaylistFeature and CrateFeature. I tried to avoid more code duplication by inheritance or using "friend" but the problem was that I would be creating a new object. There was no way of accessing the existing the objects of the said classes. Any ideas on this?
Or it will be a major task?
OR, is it best the way it is. Because using templates, inheritance, free form functions, or friend functions/classes will increase coupling? I agree that due to the decoupled nature of mixxx I only had to change one class to add both the features.

[mixxxbot]

Commented by: rawrr
Date: 2013-08-21T02:11:44Z

---

Well, it works at least. Awesome job getting the patch in! Sorry to take this long to congratulate you 9_9

Thanks so much fixing my bug!!

[mixxxbot]

Commented by: daschuer
Date: 2013-08-21T06:14:25Z

---

@vedant, are you still working on this patch? Or is it ready for review?
Can you remove the QtCreator project files? Does it merge cleanly?

@RAWRR, do you have a public GitHub branch which includes this patch. If yes, it would be helpful to issue a merge request against current mixxxdj/master branch. Thank you.

[mixxxbot]

Commented by: rawrr
Date: 2013-08-21T22:55:51Z

---

Ixnay on that, I checked in haste and under lack of sleep. I mistook the normal tree view right click feature for it 9_9

Sorry.

[mixxxbot]

Commented by: esbrandt
Date: 2013-11-09T18:27:12Z

---

Merged, see #93

[mixxxbot]

Issue closed with status Fix Released.