Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard focus gets stuck in sidebar/track list, inhibits play/pause hotkeys #13647

Open
dustinpaluch opened this issue Sep 13, 2024 · 1 comment
Labels

Comments

@dustinpaluch
Copy link

dustinpaluch commented Sep 13, 2024

Bug Description

Sometimes, despite clicking on a deck, the keyboard's focus gets stuck in the sidebar or the track list, so that when I press D to pause a deck, it just selects the next crate that starts with D in the sidebar, or the next track that starts with D in the library instead of pausing the deck.

Can't figure out how to reproduce yet, but once it happens, I can't figure out how to undo it and get the hotkeys back.

Perhaps related to #13160

Version

2.4.1

OS

macOS Sonoma 14.3.1

@ronso0
Copy link
Member

ronso0 commented Sep 23, 2024

Sometimes, despite clicking on a deck, the keyboard's focus gets stuck in the sidebar or the track list

Clicking any control or label outside the library (search, sidebar, racks) does (and should) not remove the focus from the library (exceptions are editors like the loop & beatjump size spinboxes).
This ensures there's a keyboard focus target to keep the library navigation controls working without having to set focus again. These are Up, Down, PageDown keypresses etc. and emulated keypresses for the library controls (used by controller mappings).

IINM keypresses (a-z and maybe numbers) should only jump (search) in the tracks view if no control is assigned to that specific key. Ie. the keyboard event filter should always catch those keys and trigger the repsective controls.

Please update if yo manage to reproduce.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants