Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug assert hit in DlgCoverArtFullSize #10968

Open
ronso0 opened this issue Oct 15, 2022 · 1 comment · Fixed by #10973
Open

Debug assert hit in DlgCoverArtFullSize #10968

ronso0 opened this issue Oct 15, 2022 · 1 comment · Fixed by #10973
Labels
bug

Comments

@ronso0
Copy link
Member

ronso0 commented Oct 15, 2022 •
edited
Loading

Bug Description

Hit this twice recetnly. 1st time in main IIRC, 2nd time in 2.3.4-beta after dropping a track from file manager into a deck.
Reproducible with mp3 and flac with embedded cover.

DEBUG ASSERT: "centerOverWidget" in function void DlgCoverArtFullSize::slotCoverFound(const QObject*, const CoverInfo&, const QPixmap&, quint16, bool) at /home/ronso/Downloads/mixxx_source/src/master/src/library/dlgcoverartfullsize.cpp:168

Version

2.3.4 // 2.4-alpha

OS

Ubuntu Studio 20.04 / Qt 5.12.8
@ronso0 ronso0 added the bug label Oct 15, 2022
@ronso0 ronso0 changed the title Debug assert hit in Debug assert hit in DlgCoverArtFullSize Oct 16, 2022
@ronso0
Copy link
Member Author

ronso0 commented Oct 16, 2022

regression from b8dff32#diff-b1b61c8dfee6e1e996c68cbc327f3c9f1654f5426ef92265550fe6775432c0e8R1281 on xcb
WSpinny is created with nullptr parent and that is used to create DlgCoverArtFullSize. When the parent is set for WSpinny it is not set for DlgCoverArtFullSize.

Either add WSpinny::setParent or or use WSpinny as parent for DlgCoverArtFullSize.

@ronso0 ronso0 mentioned this issue Oct 16, 2022
Merged
@ronso0 ronso0 linked a pull request Oct 17, 2022 that will close this issue
WSpinny: ensure DlgCoverArtFullSize has a parent on xcb #10973
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WSpinny: ensure DlgCoverArtFullSize has a parent on xcb ronso0/mixxx
1 participant
@ronso0