Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk appmenu #10383

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

gtk appmenu #10383

mixxxbot opened this issue Aug 23, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: gouster4
Date: 2021-04-03T19:12:41Z
Status: Won't Fix
Importance: Wishlist
Launchpad Issue: lp1922448
Tags: gui


Please implement gtk appmenu / gmenu /gtk menu or how is it called.

Here is example of Firefox with appmenu supported. Saves screen space.
https://ibb.co/6mDMMns

And here is Mixxx 2.4 without appmenu support (menu hardcoded/built into mixxx).
https://ibb.co/VCK6H6q
I see there potential to have that menu shared with system, and get rid of that panel.
I know that Mixxx is multiplatform app, but i hope it can be programmed for linux only with some function which detects used os. That way it would not affect functionality on other platforms like windows. Its just matter of getting rid of that panel, and let linux os make that panel for you, depending how configureg/customized your de is. normally it would look similar as now, but with some DE extensions you can get it to topbar.

Here is some more info about it:
https://developer.gnome.org/gtk4/stable/ch01s06.html#id-1.2.3.10.10

https://developer.gnome.org/gtk3/stable/ch01s04.html#id-1.2.3.12.8

Thanx.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-04-03T20:17:56Z


Mixxx uses Qt and not GTK. If you know how to implement the GTK app menu with Qt please share.

I doubt that this is possible with reasonable effort.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-04-03T21:26:44Z


I doubt that this is possible with reasonable effort.

Likewise. And I think it would be a big waste of time to invest that effort into the legacy QWidgets GUI instead of moving forward with QML.

@mixxxbot
Copy link
Collaborator Author

Commented by: gouster4
Date: 2021-04-04T09:46:51Z


I see, you did implemented appmenu, but trought QT. That should work aswell.
I used tool qt5ct to help appmenu integration with qt apps.

Everything seems to work fine, until i get notification about no audio output device (when starting mixxx without connected my DDJ-SB2).

Screenshots:
Before no audio output message:
https://ibb.co/859Hqyd

After no audio output message:
https://ibb.co/qnx08Ct
https://ibb.co/m4JkK2z

This also reminds me feature request.
Once i configure my DDJ-SB2 (or any other hw) as audio output/input, and then start mixxx again without hw connected, it clears my settings... is there any way to setup two or more devices for each input/output? one as Main, and second as failover which gets activated just since main isnt available.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-04-04T12:15:24Z


Please don't use the same bug report for different issues.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-04-04T12:19:44Z


This is also not a support forum. Please use https://mixxx.discourse.group/c/support/6 for this purpose. Thank you.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-04-04T20:05:22Z


@pavel Horniak (gouster4)
FWIW, I use the vala appmenu plugin in xubuntu and it works like a charm: all shortcuts are functional also in fllscreen mode.

There are also two (closed/stalled) PRs aiming to get rid of the main menu bar, you may try if one of those works for you:

#3184
closed, some unresolved issues with Unity, no testing on Windows or macOS, yet

#3189
unresolved issues, as well.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Won't Fix.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant