Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 - Improve scrolling behavior #92

Merged
merged 10 commits into from
Sep 5, 2020
Merged

Conversation

mixxorz
Copy link
Owner

@mixxorz mixxorz commented Sep 5, 2020

Issue ticket #29

If applied, this PR will...
Improve the overall scrolling behavior

  • A black gradient overlay becomes visible when scrolling through chat history
  • Clicking on the down arrow will scroll to the bottom
  • An "Unread messages" indicator becomes visible when a new message arrives while scrolling through chat history

Please provide detail on the technical changes, if relevant

  • Add FadingFrameMixin that handles all fade-in/fade-out logic.
  • Greatly simplify scrolling logic
  • Add new library LibEasing

Screenshots

WoWScrnShot_090620_023718
WoWScrnShot_090620_023710

Dev checklist

  • Feature works with other addons enabled
  • Feature works with all other addons disabled
  • README updated (if necessary)
  • CHANGELOG updated

@mixxorz mixxorz merged commit a04bcd7 into master Sep 5, 2020
@mixxorz mixxorz deleted the feature/29-scroll-position branch September 5, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant