Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak slide up animations #71

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Tweak slide up animations #71

merged 3 commits into from
Aug 25, 2020

Conversation

mixxorz
Copy link
Owner

@mixxorz mixxorz commented Aug 25, 2020

Issue ticket #67

If applied, this PR will...
Attempt to fix the jittery slide up animations some players are experiencing

Please provide detail on the technical changes, if relevant
The previous implementation works like this:

  1. Scroll frame so that new messages are at the bottom
  2. Shift slider frame down instantly (to negate the scroll frame movement)
  3. Slide up transition

Steps 1 and 2 don't always happen in the same frame, resulting in some jittering
for players with high FPS.

The new implementation works like this:

  1. Slide up animation
  2. After the animation finishes, scroll frame so that new messages are at the bottom

Based on my testing, this produced no jittering.

Dev checklist

  • Feature works with other addons enabled
  • Feature works with all other addons disabled
  • README updated (if necessary)
  • CHANGELOG updated

@mixxorz mixxorz merged commit a8d12b5 into master Aug 25, 2020
@mixxorz mixxorz deleted the fix/jittery-animations branch August 25, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant