Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation-without-for and deprecation-without-since deprecation warnings #121

Merged
merged 1 commit into from
May 28, 2021

Conversation

SergeAstapov
Copy link
Contributor

Fixes per RFC #649

@SergeAstapov
Copy link
Contributor Author

@mixonic just noticed you did the same in #118. Would you like me to withdraw this PR?

@mixonic
Copy link
Member

mixonic commented May 28, 2021

@SergeAstapov I'll merge this version and build atop it. I'm trying to split #118 into chunks anyway. It just got bigger and bigger as I found more things to clean up or fix :-p

@mixonic mixonic merged commit 48deef8 into ember-cli:master May 28, 2021
@mixonic
Copy link
Member

mixonic commented May 28, 2021

Thank you!

@SergeAstapov SergeAstapov deleted the fix-deprecation-warnings branch May 28, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants