Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deletion parameter on create replication policy #183

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add Deletion parameter on create replication policy #183

merged 1 commit into from
Nov 29, 2023

Conversation

xoanmi
Copy link
Contributor

@xoanmi xoanmi commented Nov 29, 2023

By adding the deletion param on the CreateReplicationPolicyParams{} we ensure retrocompatibility with Harbor API.

close #182

elenz97
elenz97 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@elenz97 elenz97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks for the contribution and good catch!

@elenz97 elenz97 merged commit 1bd1aeb into mittwald:master Nov 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenz97 elenz97 elenz97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Replication Policy API parameter mistmatch
2 participants
@xoanmi @elenz97