Skip to content

Commit

Permalink
*: fix panic in get cause error (tikv#1344)
Browse files Browse the repository at this point in the history
Signed-off-by: crazycs520 <[email protected]>
  • Loading branch information
crazycs520 authored May 16, 2024
1 parent c40432e commit 38e0dca
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 2 deletions.
19 changes: 17 additions & 2 deletions internal/locate/region_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,17 @@ func (r *RequestErrorStats) RecordRPCErrorStats(errLabel string) {
}
}

// getErrMsg returns error message. if the error has cause error, then return cause error message.
func getErrMsg(err error) string {
if err == nil {
return ""
}
if causeErr := errors.Cause(err); causeErr != nil {
return causeErr.Error()
}
return err.Error()
}

// String implements fmt.Stringer interface.
func (r *RegionRequestRuntimeStats) String() string {
if r == nil {
Expand Down Expand Up @@ -2115,7 +2126,7 @@ func (s *RegionRequestSender) sendReqToRegion(
if err != nil {
s.rpcError = err
if s.Stats != nil {
errStr := errors.Cause(err).Error()
errStr := getErrMsg(err)
s.Stats.RecordRPCErrorStats(errStr)
s.recordRPCAccessInfo(req, rpcCtx, errStr)
}
Expand Down Expand Up @@ -2211,7 +2222,11 @@ func (s *RegionRequestSender) onSendFail(bo *retry.Backoffer, ctx *RPCContext, r
}
}
}
metrics.TiKVRPCErrorCounter.WithLabelValues(errors.Cause(err).Error(), storeLabel).Inc()
if errStr := getErrMsg(err); len(errStr) > 0 {
metrics.TiKVRPCErrorCounter.WithLabelValues(getErrMsg(err), storeLabel).Inc()
} else {
metrics.TiKVRPCErrorCounter.WithLabelValues("unknown", storeLabel).Inc()
}

if ctx.Store != nil && ctx.Store.storeType == tikvrpc.TiFlashCompute {
s.regionCache.InvalidateTiFlashComputeStoresIfGRPCError(err)
Expand Down
18 changes: 18 additions & 0 deletions internal/locate/region_request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import (
"github.com/pingcap/kvproto/pkg/mpp"
"github.com/pingcap/kvproto/pkg/tikvpb"
"github.com/pkg/errors"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"github.com/tikv/client-go/v2/config"
"github.com/tikv/client-go/v2/config/retry"
Expand Down Expand Up @@ -872,3 +873,20 @@ func (s *testRegionRequestToSingleStoreSuite) TestRegionRequestStats() {
}
s.Contains(expecteds, access.String())
}

type noCauseError struct {
error
}

func (_ noCauseError) Cause() error {
return nil
}

func TestGetErrMsg(t *testing.T) {
err := noCauseError{error: errors.New("no cause err")}
require.Equal(t, nil, errors.Cause(err))
require.Panicsf(t, func() {
_ = errors.Cause(err).Error()
}, "should panic")
require.Equal(t, "no cause err", getErrMsg(err))
}

0 comments on commit 38e0dca

Please sign in to comment.