Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move PATH fixing out of get_pipsi #156

Open
RonnyPfannschmidt opened this issue Jun 4, 2018 · 5 comments
Open

move PATH fixing out of get_pipsi #156

RonnyPfannschmidt opened this issue Jun 4, 2018 · 5 comments

Comments

@RonnyPfannschmidt
Copy link
Contributor

followup to #148

we should strive to have a simple and straightforward get_pipsi script
as such the shell script fixing should move to a module in pipsi
(as that is usable after installation)

@cs01
Copy link
Contributor

cs01 commented Jun 4, 2018

Well that was fast. What changed your mind back?

@RonnyPfannschmidt
Copy link
Contributor Author

@cs01 the path fixing should still happen, this is about the code location - until someone demonstrates its a grave mistake im on board with it

@RonnyPfannschmidt
Copy link
Contributor Author

@cs01 i decided to make this issue right when i decided your pr is good to go, because the feature works now ^^ the rest is details that can happen later

@cs01
Copy link
Contributor

cs01 commented Jun 4, 2018

Sounds good. I'll see if I can put a PR together and some unit tests (for the other issue you made).

@RonnyPfannschmidt
Copy link
Contributor Author

@cs01 thanks, take your time, i have another pr i want to merge, then i will apply black/pre-commit to the repo and take a look at releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants