Add basic struct flattening support #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic flattening for flattening (#9). It takes advantage of the recent changes to eliminate the old
MapSink
andSeqSink
but it needs a new unvettedOwnedSlot
abstraction to allow deserializing into an adjacent slot.There is an unsafe transmute in there which only exists because the borrow checker does not really understand loops (rust-lang/rust#54663). I'm not sure if there is a way to get away without the transmute by finding some clever alternative ways to structure this code.
Remaining tasks:
skip_serializing_if
andflatten
skip_serializing_optionals
with flatten