Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdf2ckl profile w dependent fix #1481

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Conversation

vanessuniq
Copy link
Contributor

  • Fix hdf2ckl to produce a valid CKL file for InSpec results from profiles with dependent profiles by filtering out the duplicated data.
  • Updated the test for hdf2ckl

Fix #1472

@vanessuniq vanessuniq added the bug Something isn't working label Jun 13, 2023
@vanessuniq vanessuniq force-pushed the hdf2ckl_profile_w_dependent_fix branch 2 times, most recently from 398cc27 to dc8c8c5 Compare June 13, 2023 17:34
@aaronlippold
Copy link
Member

aaronlippold commented Jun 13, 2023

Does this account for both types of dependent profiles:

Wrapper: Wide layer with multiple benchmarks at the same level

  • Expected Outcome:
    a) Create multiple checklists,
    b) the user can ask for a 'grouped single checklist'

Overlay: Parent/Child/grand-child chain

  • Expected Outcome: Create a single checklist file

@Hookwitz
Copy link
Contributor

@aaronlippold this will address the overlay. I do not believe either export functionality (Heimdall or SAF CLI) contains the capability to split into multiple checklists nor provides user input.

…om profiles with dependent profiles

Signed-off-by: Vanessa Fotso <[email protected]>
@vanessuniq vanessuniq force-pushed the hdf2ckl_profile_w_dependent_fix branch from 0ad635d to 6b60602 Compare June 14, 2023 15:27
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is good code-wise. Just waiting for @rlakey to validate it works for him before merge.

@rlakey
Copy link

rlakey commented Jun 21, 2023

Looks like that worked for me on the same results json in the issue.

image

@vanessuniq vanessuniq enabled auto-merge (squash) June 21, 2023 23:25
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vanessuniq vanessuniq merged commit e2d6ac7 into main Jun 21, 2023
@mergify mergify bot deleted the hdf2ckl_profile_w_dependent_fix branch June 21, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
6 participants