Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connecting SAF CLI to new Checklist Mapper #1160

Merged
merged 9 commits into from
Jun 23, 2023
Merged

Connecting SAF CLI to new Checklist Mapper #1160

merged 9 commits into from
Jun 23, 2023

Conversation

Hookwitz
Copy link
Contributor

@Hookwitz Hookwitz commented Mar 1, 2023

No description provided.

initial file commit
30b48ee 
Signed-off-by: David Markowski <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Amndeep7 Amndeep7 marked this pull request as draft March 10, 2023 21:22
@Amndeep7 Amndeep7 changed the title [WIP] Connecting SAF CLI to new Checklist Mapper Connecting SAF CLI to new Checklist Mapper Mar 10, 2023
David Markowski and others added 4 commits June 5, 2023 10:46
@Hookwitz Hookwitz marked this pull request as ready for review June 23, 2023 14:53
Amndeep7
Amndeep7 requested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good for the most part. ideally can be merged today

README.md Outdated Show resolved Hide resolved
test/commands/utils.ts Show resolved Hide resolved
@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Jun 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify mergify bot merged commit 906de6a into main Jun 23, 2023
@mergify mergify bot deleted the checklistConverter branch June 23, 2023 19:36
aaronlippold
aaronlippold reviewed Jun 23, 2023
View reviewed changes
README.md
@@ -939,6 +937,36 @@ convert zap2hdf Translate a OWASP ZAP results JSON to a Heimdall D

---

### Non-HDF Converters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other Useful Converters vs Non-HDF may be a bit better

@Hookwitz Hookwitz mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlippold aaronlippold aaronlippold left review comments

@Amndeep7 Amndeep7 Amndeep7 approved these changes

Assignees
No one assigned
Labels
ready-to-merge Used by mergify to identify if a PR is ready to merge into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hookwitz @aaronlippold @Amndeep7