Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cross-spawn from 7.0.3 to 7.0.6 #1834

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 19, 2024

Bumps cross-spawn from 7.0.3 to 7.0.6.

Changelog

Sourced from cross-spawn's changelog.

7.0.6 (2024-11-18)

Bug Fixes

  • update cross-spawn version to 7.0.5 in package-lock.json (f700743)

7.0.5 (2024-11-07)

Bug Fixes

  • fix escaping bug introduced by backtracking (640d391)

7.0.4 (2024-11-07)

Bug Fixes

Commits
  • 77cd97f chore(release): 7.0.6
  • 6717de4 chore: upgrade standard-version
  • f700743 fix: update cross-spawn version to 7.0.5 in package-lock.json
  • 9a7e3b2 chore: fix build status badge
  • 0852683 chore(release): 7.0.5
  • 640d391 fix: fix escaping bug introduced by backtracking
  • bff0c87 chore: remove codecov
  • a7c6abc chore: replace travis with github workflows
  • 9b9246e chore(release): 7.0.4
  • 5ff3a07 fix: disable regexp backtracking (#160)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 19, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be failing due to

#16 [12/12] RUN yarn build
#16 1.517  ⨯ Failed to load next.config.js, see more info here https://nextjs.org/docs/messages/next-config-error
#16 1.527 
#16 1.527 > Build error occurred
#16 1.531 Error [ValidationError]: NEXT_PUBLIC_CSRF_COOKIE_NAME is a required field
#16 1.531     at createError (/app/node_modules/yup/index.js:346:21)
#16 1.531     at handleResult (/app/node_modules/yup/index.js:363:104)
#16 1.531     at validate (/app/node_modules/yup/index.js:386:5)
#16 1.531     at StringSchema.runTests (/app/node_modules/yup/index.js:751:7)
#16 1.531     at <unknown> (/app/node_modules/yup/index.js:706:12)
#16 1.531     at nextOnce (/app/node_modules/yup/index.js:737:7)
#16 1.531     at finishTestRun (/app/node_modules/yup/index.js:756:11)
#16 1.531     at handleResult (/app/node_modules/yup/index.js:363:124)
#16 1.531     at validate (/app/node_modules/yup/index.js:386:5)
#16 1.531     at StringSchema.runTests (/app/node_modules/yup/index.js:751:7) {
#16 1.531   value: [Object],
#16 1.531   path: 'NEXT_PUBLIC_CSRF_COOKIE_NAME',
#16 1.531   type: 'required',
#16 1.531   params: [Object],
#16 1.531   errors: [Array],
#16 1.531   inner: []
#16 1.531 }

@jonkafton
Copy link
Contributor

I haven't made much sense of the build failure. NEXT_PUBLIC_CSRF_COOKIE_NAME is present on the Docker build args in the Actions job. The error is from ./frontends/main/src/validateEnv.js, called in the Next.js config file. next build does spawn child processes, https://github.com/vercel/next.js/blob/canary/scripts/pack-util.cjs#L47, but passes through the process.env.

cross-spawn is however only in use by jest and eslint (dependency tree below) and does not appear to augment the native child-process module. It does augment child process instances here, but I'mm not seeing any scenario that can happen without calling spawn on the package.

It is also passing now without any code change.

├─ api@workspace:frontends/api
│  └─ jest@npm:29.7.0 [0308d] (via npm:^29.7.0 [0308d])
│     ├─ @jest/core@npm:29.7.0 [3c1cd] (via npm:^29.7.0 [3c1cd])
│     │  ├─ @jest/transform@npm:29.7.0 (via npm:^29.7.0)
│     │  │  └─ jest-haste-map@npm:29.7.0 (via npm:^29.7.0)
│     │  │     └─ fsevents@patch:fsevents@npm%3A2.3.3#optional!builtin<compat/fsevents>::version=2.3.3&hash=df0bf1 (via patch:fsevents@npm%3A^2.3.2#optional!builtin<compat/fsevents>)
│     │  │        └─ node-gyp@npm:10.2.0 (via npm:latest)
│     │  │           └─ glob@npm:10.4.5 (via npm:^10.3.10)
│     │  │              └─ foreground-child@npm:3.3.0 (via npm:^3.1.0)
│     │  │                 └─ cross-spawn@npm:7.0.6 (via npm:^7.0.0)
│     │  ├─ jest-changed-files@npm:29.7.0 (via npm:^29.7.0)
│     │  │  └─ execa@npm:5.1.1 (via npm:^5.0.0)
│     │  │     └─ cross-spawn@npm:7.0.6 (via npm:^7.0.3)
│
├─ frontends@workspace:frontends
│  ├─ @next/eslint-plugin-next@npm:14.2.15 (via npm:^14.2.7)
│  │  └─ glob@npm:10.3.10 (via npm:10.3.10)
│  │     └─ foreground-child@npm:3.3.0 (via npm:^3.1.0)
│  ├─ eslint@npm:8.57.1 (via npm:8.57.1)
│  │  └─ cross-spawn@npm:7.0.6 (via npm:^7.0.2)

@jonkafton jonkafton dismissed shanbady’s stale review November 20, 2024 19:14

Not able to identify root cause of previous failure and it has run successfully several times https://github.com/mitodl/mit-learn/actions/runs/11937139996?pr=1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants