Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation copy #532

Closed
noisecapella opened this issue Jun 10, 2016 · 4 comments
Closed

Fix validation copy #532

noisecapella opened this issue Jun 10, 2016 · 4 comments
Assignees

Comments

@noisecapella
Copy link
Contributor

noisecapella commented Jun 10, 2016

Forgot to fix this before #504 was merged. From #504 (comment)

For the first one, I think it would be good to give the user some guidance on what to do, e.g.

"A Master's Degree is required if the Master's Degree switch is on. Click the + button to add a degree or switch it off"

... that's probably too long though.

What's the user supposed to do in the 2nd case, on L103?

@pdpinch pdpinch added this to the Independence Day milestone Jun 21, 2016
@noisecapella noisecapella self-assigned this Jun 23, 2016
@noisecapella
Copy link
Contributor Author

Here's what I have so far. It needs some work, any comments so far?

screenshot from 2016-06-23 11-50-52

@roberthouse54
Copy link
Contributor

To be honest, I wonder if we can hold off on this. I feel that I want to probably redesign this sign up flow in a way to get rid of the switches completely. The switches UI paradigm makes no sense to me.

@Ferdi
Copy link
Contributor

Ferdi commented Jun 23, 2016

OK to redesign but can we put some text there until that happens?

@roberthouse54
Copy link
Contributor

OK, go with this then:

eg.

"Master's Degree is required if the switch is on. Please add a degree or switch it off."

Also, please make sure the text is aligned with the header above it. It is a bit too far left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants