Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce heading font size within docstrings #383

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

mhils
Copy link
Member

@mhils mhils commented Apr 20, 2022

This PR reduces the font size of headings in docstrings to more reasonable sizes. On top of that, I've been experimenting with different indentations as discussed in #375. Here are the three candidates for now:

A B C
image image image

Still haven't made up my mind, feedback welcome. 😃

@jacksund
Copy link
Contributor

Looks great! Thanks for working on this.

Of the three candidates you show, I'm partial to B. It's the most visually definitive when it comes to categorizing docstring text. Then candidate C is a close second. 🚀

@mhils
Copy link
Member Author

mhils commented May 4, 2022

I've polled a few folks at work, the majority prefers B. I think it's a reasonable compromise, let's go with it! 😃

@mhils mhils enabled auto-merge May 4, 2022 11:35
@mhils mhils merged commit deaed4e into mitmproxy:main May 4, 2022
@mhils mhils deleted the issue-375 branch May 4, 2022 11:39
@jacksund
Copy link
Contributor

jacksund commented May 4, 2022

awesome! thanks again for implementing this 🥳

@martinbenes1996
Copy link

Yep, B is the best.

@davfsa davfsa mentioned this pull request May 10, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants