This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
add --delete flag to rsync command #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense, and better matches behavior of "real" shared directories behave (say in virtualbox).
|
I was just having issues with this, I think it makes perfect sense to have the |
|
👍 |
|
@mitchellh - I think this should be the default behavior. It interacts with --exclude in a predictable way. But I am concerned about merging this, because the change may delete some important files stashed on an instance. In case someone relies on the current behavior. |
|
@vasili-zolotov I think this is a good change, I'll add an entry to the changelog about it to make sure it's somewhat clear. |
rtyler
pushed a commit
that referenced
this pull request
May 30, 2014
add --delete flag to rsync command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes more sense, and better matches behavior of "real" shared directories behave (say in virtualbox).