solution for booking date bug #18 #23
Conversation
fetching changes from mitch0000001/go-hbci/master
|
hopefully fixed the linting (code climate) bug now |
| testdata string | ||
| expectedBookingDate string | ||
| today string | ||
| balanceStartBookingDateString string |
There was a problem hiding this comment.
As we are already using the dates as time.Time in line 202ff we should change the type from string to time.Time. Also, the setup gets easier as we don't have to parse the date strings
| @@ -15,6 +15,7 @@ import ( | |||
|
|
|||
| // MT940 represents a S.W.I.F.T. Transaction Report | |||
| type MT940 struct { | |||
| ReferenceDate time.Time | |||
There was a problem hiding this comment.
when I read it correctly you're using ReferenceDate as a way for dependency injection. As the value is always hardcoded to time.Now at element.swift.go:30. What do you think about not exposing it yet and guarding against zero value within the Unmarshal method at swift/mt940_unmarshaler.go:12?
| monthDiff := int(math.Abs(float64(t.ValutaDate.Month() - t.BookingDate.Month()))) | ||
| if monthDiff > 1 { | ||
| diff := t.ValutaDate.Sub(t.BookingDate.Time).Hours() / 24 | ||
| if diff > 31 { |
There was a problem hiding this comment.
Unfortunately I haven't yet understood what we're calculating here and why we're checking for 31.
There was a problem hiding this comment.
how may days can be between a booking and a valuta date? I am sure it us less then 31 days.
There was a problem hiding this comment.
regarding this thread https://homebanking-hilfe.de/forum/topic.php?t=8970 which may or may not be representative the number of days can be way higher
No description provided.