From 8360733b9f73d6edeb61393d5f3b1f0b38a8042a Mon Sep 17 00:00:00 2001 From: Jason Gross Date: Fri, 10 May 2024 10:09:19 -0700 Subject: [PATCH] Disable implicit suffix rules in submakefiles (#1902) I believe this was causing issues, e.g., [here](https://github.com/mit-plv/fiat-crypto/actions/runs/9023963682/job/24799935044?pr=1898#step:5:39) when uploaded artifacts failed to preserve relative timestamps on .o files vs output executables, and as a result invoked automatic [suffix rules](https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html) and failed. --- Makefile.config | 2 ++ Makefile.coq.local | 2 ++ Makefile.examples | 2 ++ Makefile.js-html | 2 ++ Makefile.standalone | 2 ++ 5 files changed, 10 insertions(+) diff --git a/Makefile.config b/Makefile.config index 57f911bb2e..7546bc3308 100644 --- a/Makefile.config +++ b/Makefile.config @@ -1,3 +1,5 @@ +.SUFFIXES: + SKIP_BEDROCK2?= VERBOSE?= diff --git a/Makefile.coq.local b/Makefile.coq.local index 6ab411d5c5..41e9fe8fd1 100644 --- a/Makefile.coq.local +++ b/Makefile.coq.local @@ -1,3 +1,5 @@ +.SUFFIXES: + PROFILE?= OTHERFLAGS += -w -notation-overridden,-deprecated-hint-constr,-fragile-hint-constr,-native-compiler-disabled,-ambiguous-paths,-masking-absolute-name ifneq ($(PROFILE),) diff --git a/Makefile.examples b/Makefile.examples index ef62196e2b..5b0905b770 100644 --- a/Makefile.examples +++ b/Makefile.examples @@ -4,6 +4,8 @@ # this makefile directly as long as the compiled binaries are lying # around +.SUFFIXES: + include Makefile.config CFLAGS?= diff --git a/Makefile.js-html b/Makefile.js-html index 9962d226d8..cfdfde1089 100644 --- a/Makefile.js-html +++ b/Makefile.js-html @@ -1,3 +1,5 @@ +.SUFFIXES: + EXTRA_HTML_VERSION_INFO?= .PHONY: fiat-html/version.js diff --git a/Makefile.standalone b/Makefile.standalone index 321409293a..ae1ed6d5a0 100644 --- a/Makefile.standalone +++ b/Makefile.standalone @@ -2,6 +2,8 @@ # files on .v files, so that we can compile them by invoking this # makefile directly even when Coq is not available +.SUFFIXES: + SELF_MAKEFILE_STANDALONE := $(lastword $(MAKEFILE_LIST)) include Makefile.config