You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your work! Can we please make orjson dependency optional? I have concerns about the quality of this dependency (compatibility, security) and would prefer to not use it in my projects.
For example ijl/orjson#452 talks about python segfault that was introduced in one of the releases, and it took multiple iterations to get it fixed properly:
My suggestion would be to drop the orjson dependency in exchange for https://jcristharif.com/msgspec and made it optional, just for the people who really need it - the performance gain here is most likely very small and for many people it's probably not worth the additional dependency/risk. We are not parsing megabytes/gigabytes of data - stdlib's json should do pretty well.
The text was updated successfully, but these errors were encountered:
Thank you for your work! Can we please make orjson dependency optional? I have concerns about the quality of this dependency (compatibility, security) and would prefer to not use it in my projects.
For example ijl/orjson#452 talks about python segfault that was introduced in one of the releases, and it took multiple iterations to get it fixed properly:
format_escaped_str
, again ijl/orjson#457format_escaped_str
, again ijl/orjson#459You will also see that this project has 1-week stale auto-close policy, which is yet another red flag for me.
See:
My suggestion would be to drop the orjson dependency in exchange for https://jcristharif.com/msgspec and made it optional, just for the people who really need it - the performance gain here is most likely very small and for many people it's probably not worth the additional dependency/risk. We are not parsing megabytes/gigabytes of data - stdlib's json should do pretty well.
The text was updated successfully, but these errors were encountered: