Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make orjson an optional dependency #71

Closed
Zaczero opened this issue Mar 14, 2024 · 2 comments
Closed

Make orjson an optional dependency #71

Zaczero opened this issue Mar 14, 2024 · 2 comments

Comments

@Zaczero
Copy link

Zaczero commented Mar 14, 2024

Thank you for your work! Can we please make orjson dependency optional? I have concerns about the quality of this dependency (compatibility, security) and would prefer to not use it in my projects.

For example ijl/orjson#452 talks about python segfault that was introduced in one of the releases, and it took multiple iterations to get it fixed properly:

You will also see that this project has 1-week stale auto-close policy, which is yet another red flag for me.

See:

My suggestion would be to drop the orjson dependency in exchange for https://jcristharif.com/msgspec and made it optional, just for the people who really need it - the performance gain here is most likely very small and for many people it's probably not worth the additional dependency/risk. We are not parsing megabytes/gigabytes of data - stdlib's json should do pretty well.

@sophiamyang
Copy link
Contributor

Thanks for reporting the issue. I don't think orjson is a dependency anymore according to https://github.com/mistralai/client-python/blob/main/pyproject.toml. Please let us know if you see more issues. Thanks!

@Zaczero
Copy link
Author

Zaczero commented Aug 12, 2024

Indeed it is not 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants