Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible range prevents autorotate #802

Closed
haldo98 opened this issue Dec 19, 2022 · 3 comments
Closed

Visible range prevents autorotate #802

haldo98 opened this issue Dec 19, 2022 · 3 comments
Labels
Milestone

Comments

@haldo98
Copy link

haldo98 commented Dec 19, 2022

Describe the bug

I have autorotate plugin with this configuration:

   [PhotoSphereViewer.AutorotatePlugin, {
     autostartDelay: 3000,
     autorotateSpeed: 0.12,
     autorotateZoomLvl: 2,
     autostartOnIdle: false,
   }],

when I zoom in manually and then hit the autorotate button the pano zoom out to the "autorotateZoomLvl" and then perform the rotation.

But when I click on a marker from the marker list that has the "zoomLvl" set, then I hit the autorotate button the pano zoom out to the "autorotateZoomLvl" but the autorotation is not performed.

Check the online demo

Online demo URL

https://www.tadini.it/panorama/verezzi/panorama_verezzi.htm

Photo Sphere Viewer version

5.0

Plugins loaded

autorotate, compass, markers, visible-range

three.js version

https://cdn.jsdelivr.net/npm/three/build/three.min.js

OS & browser

win11 - chrome 108

Additional context

No response

@haldo98 haldo98 added the bug label Dec 19, 2022
@mistic100 mistic100 added this to the 5.0.1 milestone Dec 20, 2022
@mistic100 mistic100 changed the title Autorotate and marker zoomLvl Visible range prevents autorotate Dec 20, 2022
@mistic100
Copy link
Owner

Once again this is caused by the visible range plugin, and once again it will be an headache.
(it has nothing to do with teh markers plugin, you can manually zoom near the blue marker and the behaviour will be the same)

@mistic100 mistic100 removed this from the 5.0.1 milestone Dec 20, 2022
@mistic100 mistic100 added this to the 5.1.0 milestone Jan 10, 2023
@mistic100
Copy link
Owner

Fixed by forcing to change the zoom level before starting the rotation

@github-actions
Copy link

This feature/bug fix has been released in version 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants