Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Jerk" when panning #723

Closed
mikepianka opened this issue Aug 18, 2022 · 4 comments
Closed

"Jerk" when panning #723

mikepianka opened this issue Aug 18, 2022 · 4 comments
Labels
Milestone

Comments

@mikepianka
Copy link

When panning in the viewer with the inertia setting enabled, the is an odd visual "jerk" on release of the click where inertia takes over. See below video of the playground example.

With inertia setting on:

inertia.mp4

With inertia setting off:

no_inertia.mp4
@mistic100
Copy link
Owner

If you have an implementation proposal feel free to contribute. Personnally I was never able to fix this.

For the reference, both "competing" librairies, Panolens and Pannellum, have similar problems.
In PSV in only happens when doing a short & fast move and release the mouse button before ~500ms.

@mistic100
Copy link
Owner

Okay so... the code managing the inertia was 5 years old, and utterly flawed. I am even suprised it worked at all.

Now it is fixed

@mikepianka
Copy link
Author

mikepianka commented Aug 19, 2022

@mistic100 your change definitely helped. I made PR #726 which should make it even smoother. I think the key is using an easing method with a more linear start to avoid an acceleration bump for small mouse moves.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This feature/bug fix has been released in version 4.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants