Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The panorama can't be loaded" when switching too fast in VirtualTourPlugin #608

Closed
jonasgeiler opened this issue Dec 20, 2021 · 3 comments
Labels
Milestone

Comments

@jonasgeiler
Copy link

Hey there!
I'm using the virtual tour plugin with the "markers" mode, and I've noticed that the plugin throws an error if you switch the current node too fast (without waiting for animation to finish, etc.).
So to reproduce you basically just have to do:

virtualTour.setCurrentNode('<first node>');
virtualTour.setCurrentNode('<second node>');
virtualTour.setCurrentNode('<third node>');

The problem is that two markers with the same ID can't exist at the same time, which happens when the plugin doesn't have time to finish removing the old markers.

Here's a demo: JSFiddle

Versions:

  • Photo Sphere Viewer: 4.4.1
  • three.js: 0.135.0
  • Browser: Chrome 96.0.4664.110 (Official Build) (arm64)
@mistic100 mistic100 added the bug label Dec 21, 2021
@mistic100 mistic100 added this to the 4.4.2 milestone Dec 21, 2021
@mistic100
Copy link
Owner

Just discovered another error in the cancellation system #611, it will need to be fixed first.

@jonasgeiler
Copy link
Author

Thanks for the fix! Do you know when you'll release 4.4.2 because I really need that bug fix 😅

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This feature/bug fix has been released in version 4.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants