-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisibleRangePlugin is doing nothing with npm install #588
Comments
Is there any error in the console ? Also you should upgrade to import { VisibleRangePlugin } from 'photo-sphere-viewer/dist/plugins/visible-range'; the other form is still compatible be this one is more modern |
It looks like adding the brackets fixes the issues.. That is weird. And no, there were no errors in the console, it just looked like nothing was being run at all. |
Can you share you builder configuration ? I made a test yesterday with rollup.js to bundle an app and it was working with both syntaxes. |
I tried with webpack and the problem seems to be with the default interop, because plugins don't have a default export anymore. There is some compatibility code in the Viewer itself but it cannot handle this case. When doing a default import, Rollup returns the "default" property if it exists or the whole module, so it works. Webpack on the other and always returns "default", and it is undefined in this case. One solution is for me is to rebuild the lib with |
This feature/bug fix has been released in version 4.4.0. |
Versions, all installed with npm:
Photo-Sphere-Viewer: "4.3.0"
three": "^0.133.1",
I have read the documentation on the VisibleRangePlugin and have tried everything but cant seem to produce any visual difference at all. No matter what I do Im still always able to rotate a 360 x 180 sphere.
Im using cropped images with values suggested from the playgroud.
This is what I have so far:
I have also tried setting the ranges object to:
as suggested in the documentation. This also has no effect at all.
What am I missing here?
The text was updated successfully, but these errors were encountered: