Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VR mode does not work on iPhone #209

Closed
xvlm opened this issue Jul 9, 2018 · 4 comments
Closed

VR mode does not work on iPhone #209

xvlm opened this issue Jul 9, 2018 · 4 comments
Milestone

Comments

@xvlm
Copy link

xvlm commented Jul 9, 2018

V3.4.0
No change after clicking on the VR icon.
But it works on Android.

@mistic100
Copy link
Owner

If you can try to debug and submit a fix, please do.
I don't have access to an iPhone.

@Blindmikey
Copy link

Just adding some detail - console error thrown when clicking to utilize vr on iphone:

TypeError: undefined is not an object (evaluating '(t.requestFullscreen||t.mozRequestFullScreen||t.webkitRequestFullscreen||t.msRequestFullscreen).call')

@Blindmikey
Copy link

Some further sleuthing shows that mobile iOS doesn't support the fullScreen API.
https://caniuse.com/#feat=fullscreen

A potential solution might be the old .webkitEnterFullscreen() method, though a preliminary addition of that function in the following list did not immediately solve the problem.

(t.requestFullscreen||t.mozRequestFullScreen||t.webkitRequestFullscreen||t.msRequestFullscreen||t.webkitEnterFullscreen).call

@mistic100
Copy link
Owner

Ok I forgot that, well the solution will be simple : disable the button when fullscreen is not supported (it's already the case for the "fullscreen" button which is hidden on iOS).

I will not spend my time trying to achieve a degraded mode when Apple decides to not even implement the basic web APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants