Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VirtualTourPlugin] updateNode function throws typeError 'gps is undefined' #1471

Closed
Hafdoune opened this issue Oct 26, 2024 · 2 comments
Closed
Labels
Milestone

Comments

@Hafdoune
Copy link

Describe the bug

virtualTourPlugin.updateNode({
id: '1',
panorama: baseUrl + 'tour/key-biscayne-7.jpg',
thumbnail: baseUrl + 'tour/key-biscayne-7-thumb.jpg',
name: 'Seven',
caption: [7] ${caption},
links: [{ nodeId: '6' }],
gps: [-80.15707, 25.6665, 3],
sphereCorrection: { pan: '110deg', pitch: -3 },
});
image

Online demo URL

No response

Photo Sphere Viewer version

5.11.1

Plugins loaded

No response

OS & browser

Firefox

Additional context

No response

@Hafdoune Hafdoune added the bug label Oct 26, 2024
@mistic100
Copy link
Owner

Ok this happens because the "gps" value of the linked node is not correctly copied from node 6.

In the mean time you can redeclare it :

...
links: [{ nodeId: '6', gps: [lat, long] }],
...

@mistic100 mistic100 added this to the 5.11.2 milestone Oct 27, 2024
Copy link

This feature/bug fix has been released in version 5.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants