Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobile] Double pause icon #85

Closed
rtritto opened this issue Nov 23, 2022 · 7 comments · Fixed by #130
Closed

[mobile] Double pause icon #85

rtritto opened this issue Nov 23, 2022 · 7 comments · Fixed by #130

Comments

@rtritto
Copy link

rtritto commented Nov 23, 2022

image

video_2022-11-24_20-14-33.mp4

Repro

Details

scss content:

@charset 'utf-8';
@import 'video.js/src/css/video-js.scss';
@import 'videojs-mobile-ui/src/plugin.css';

Versions

video.js: 8.0.2
videojs-mobile-ui: 1.0.0

@mister-ben
Copy link
Owner

I can't reproduce. Do you have a simple live example?

@rtritto
Copy link
Author

rtritto commented Nov 24, 2022

Added a video and tested with video.js v8.0.2.

@mister-ben
Copy link
Owner

mister-ben commented Nov 25, 2022

A video isn't any more useful to reproduce an issue as a sreenshot unfortunately. Can you add a reproduceable, live example, e.g. on codesandox or similar?

@rtritto
Copy link
Author

rtritto commented Nov 25, 2022

Added repro

@mister-ben
Copy link
Owner

This is because sass is changing the order of the CSS it outputs, putting the videojs-mobile-ui styles before the video.js styles. It also occurs in your example if I change the versions to 0.7.0/^7. I could make the styles in this plugin more specific, but I imagine it's not the only problem you'll run into if the order of css isn't preserved.

@rtritto
Copy link
Author

rtritto commented May 31, 2023

@mister-ben any updates?

@rtritto
Copy link
Author

rtritto commented Jun 2, 2023

@mister-ben do you have a workaround?

Maybe adding a display: none to initial css of video.js

FYI @gkatsev

@rtritto rtritto changed the title Second play toggle on top [mobile] Double pause icon Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants