Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): scss deprecated 警告に対応 #14513

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 6, 2024

What

フロントエンドビルド時にsassから出ていた警告に対応した

ネイティブのnested cssでは、nested rulesの前後に存在する同レベルのスタイル定義は別ブロックとして認識されてしまう(scssでは同レベルのスタイル定義はすべて同じブロックに入るようになっていた)ため、同レベルの定義をすべて同じカタマリに移動

image

詳細: https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Why

  • 警告はないほうがいいので
  • 近いうちにsassのcss解釈が変わってしまうので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.

Project coverage is 20.16%. Comparing base (3fe7e37) to head (c605534).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/_common_/statusbars.vue 0.00% 8 Missing ⚠️
...ckages/frontend/src/pages/admin/overview.users.vue 0.00% 4 Missing ⚠️
packages/frontend/src/components/MkSuperMenu.vue 0.00% 3 Missing ⚠️
packages/frontend/src/ui/deck/column.vue 0.00% 3 Missing ⚠️
packages/frontend/src/pages/page.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14513      +/-   ##
===========================================
- Coverage    20.17%   20.16%   -0.02%     
===========================================
  Files          725      725              
  Lines       100502   100568      +66     
  Branches      1045     1045              
===========================================
  Hits         20279    20279              
- Misses       79681    79747      +66     
  Partials       542      542              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit cdb0566 into misskey-dev:develop Sep 6, 2024
18 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 6, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-remove-deprecated-sass-rules branch September 6, 2024 07:13
@kakkokari-gtyih kakkokari-gtyih mentioned this pull request Sep 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants