Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): server metrics look strange after reload #14467

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

zyoshoka
Copy link
Contributor

What

サーバーメトリクスが2つ以上あるとリロード直後の表示がおかしくなる問題を修正します。

Why

Closes #14463

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 20.02%. Comparing base (44f6216) to head (913c23b).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/frontend/src/widgets/server-metric/cpu-mem.vue 0.00% 1 Missing ⚠️
...ackages/frontend/src/widgets/server-metric/net.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14467      +/-   ##
===========================================
- Coverage    20.21%   20.02%   -0.19%     
===========================================
  Files          725      725              
  Lines       100550   100550              
  Branches      1050     1052       +2     
===========================================
- Hits         20327    20137     -190     
- Misses       79681    79869     +188     
- Partials       542      544       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 🙏🏻
メモ: MDN

@syuilo syuilo merged commit 3fe7e37 into misskey-dev:develop Aug 30, 2024
17 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 30, 2024

🙏🏿

@zyoshoka zyoshoka deleted the server-metrics branch August 30, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple server metrics causes display problems immediately after reload
3 participants