Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): correct condition to displayed as system account on moderation page #14407

Conversation

zyoshoka
Copy link
Contributor

What

ユーザーのモデレーションページにおいてユーザー名にドットが入っているとシステムアカウントとして表示されてしまう問題を修正します。

Why

#11135 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.25%. Comparing base (41936c1) to head (d9a1b63).
Report is 6 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/admin-user.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14407       +/-   ##
============================================
- Coverage    39.91%   20.25%   -19.67%     
============================================
  Files         1545      723      -822     
  Lines       190505   100283    -90222     
  Branches      2654     1049     -1605     
============================================
- Hits         76046    20308    -55738     
+ Misses      113898    79434    -34464     
+ Partials       561      541       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 15, 2024
@syuilo syuilo merged commit 2632204 into misskey-dev:develop Aug 16, 2024
16 of 17 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 16, 2024

🙏🏻

@zyoshoka zyoshoka deleted the fix-user-displayed-as-system-account-if-username-includes-dot branch August 16, 2024 13:46
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants