Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ページ遷移に失敗することがある問題を修正 (bump vue version) #14380

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Vue v3.4.37にアップデート

Why

Fix #14170

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 8, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.26%. Comparing base (61eec93) to head (bacfac8).
Report is 261 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14380       +/-   ##
============================================
- Coverage    66.21%   20.26%   -45.96%     
============================================
  Files          990      722      -268     
  Lines       117137   100230    -16907     
  Branches      4489     1048     -3441     
============================================
- Hits         77568    20308    -57260     
- Misses       39538    79382    +39844     
- Partials        31      540      +509     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha
Copy link
Contributor

tai-cha commented Aug 9, 2024

3.4.34 -> 3.4.37間の差分はBug Fixes, Performance Improvementsのみっぽいのであまり注意してアプデしなくてもよいかも
https://github.com/vuejs/core/blob/main/CHANGELOG.md#3437-2024-08-08

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう (14170が改善されるかどうかは見てない)

@tai-cha
Copy link
Contributor

tai-cha commented Aug 9, 2024

/preview

Copy link
Contributor

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

該当Issueと同じ手順ではないけれど設定→コントロールパネル→設定→コントロールパネルをさらに繰り返す場合のケースでのページ描画が正常に行える改善が確認できたので更新自体はした方がよさそう

@syuilo syuilo merged commit 7e3dedb into misskey-dev:develop Aug 10, 2024
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 10, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14170-1 branch August 10, 2024 01:39
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…4380)

* fix(frontend): ページ遷移に失敗することがある問題を修正 (bump vue version)

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

特定の手順を踏むとページが正常に描画されない
4 participants